Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pullSource tests as table driven format #1826

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

QiWang19
Copy link
Collaborator

@QiWang19 QiWang19 commented Feb 2, 2023

Follow-up PR: #1411 (comment)
Merge the test and test data of TestPullSourcesMirrorFromReference to TestPullSourcesFromReference

Signed-off-by: Qi Wang [email protected]

@QiWang19
Copy link
Collaborator Author

QiWang19 commented Feb 3, 2023

@vrothberg @mtrmac PTAL

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

pkg/sysregistriesv2/system_registries_v2_test.go Outdated Show resolved Hide resolved
@QiWang19
Copy link
Collaborator Author

QiWang19 commented Feb 9, 2023

@mtrmac PTAL

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall, last round of smaller things.

pkg/sysregistriesv2/system_registries_v2_test.go Outdated Show resolved Hide resolved
@TomSweeneyRedHat
Copy link
Member

LGTM, once @mtrmac comments are addressed. Looks like you need a rebase too @QiWang19

Follow up PR: containers#1411 (comment)
Merge the test and test data of TestPullSourcesMirrorFromReference to TestPullSourcesFromReference

Signed-off-by: Qi Wang <[email protected]>
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@QiWang19
Copy link
Collaborator Author

@mtrmac PTAL. Tests are green.

@mtrmac mtrmac merged commit bdc5f13 into containers:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants