Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that cleartext signatures are not accepted in simple signing #1854

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Feb 17, 2023

The current implementation transparently accepts them in gpgmeSigningMechanism , but openpgpSigningMechanism rejects them; so make it clear that they should be rejected.

See #1852 .

…gning

The current implementation transparently accepts them in gpgmeSigningMechanism ,
but openpgpSigningMechanism rejects them; so make it clear that they should
be rejected.

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac added the kind/bug A defect in an existing functionality (or a PR fixing it) label Feb 17, 2023
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 282854d into containers:main Feb 17, 2023
@mtrmac mtrmac deleted the sigs-not-armor branch February 17, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants