Fix builds of the ostree transport #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken since c/image 5.22.0 ... Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m afraid I broke this during refactoring; we’ve been releasing broken
ostreesince c/image 5.22.0 (Jul 2022)It’s tempting to conclude that if no-one has noticed in that time, we really might be able to drop the transport without noticeably breaking API.
This was reported in containers/skopeo#1917 , with the suggestion that the reporter might volunteer to maintain the transport. So, let’s concentrate the discussion about the future of that transport in that other issue.
I have verified that this allows the transport to build; I didn’t actually try using it.