Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to verify a signature with a set of fingerprints #1904

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Add ability to verify a signature with a set of fingerprints #1904

merged 1 commit into from
Apr 1, 2023

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Mar 30, 2023

@Jamstah
Copy link
Contributor Author

Jamstah commented Mar 30, 2023

I should probably make it return the selected fingerprint. If I don't do it now it's hard to change the API later.

@Jamstah Jamstah marked this pull request as draft March 30, 2023 18:57
@Jamstah Jamstah force-pushed the verify-with-multiple-fingerprints branch from e4d7125 to 9d78883 Compare March 30, 2023 23:39
@Jamstah Jamstah mentioned this pull request Mar 30, 2023
Merged
@Jamstah Jamstah force-pushed the verify-with-multiple-fingerprints branch from 9d78883 to c6bbbc0 Compare March 31, 2023 00:39
@Jamstah Jamstah marked this pull request as ready for review March 31, 2023 09:32
mtrmac
mtrmac reviewed Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, just a few nits.

signature/docker.go Outdated Show resolved Hide resolved
signature/docker.go Outdated Show resolved Hide resolved
signature/docker.go Outdated Show resolved Hide resolved
@Jamstah Jamstah force-pushed the verify-with-multiple-fingerprints branch 2 times, most recently from 038fb0d to c2236bd Compare March 31, 2023 11:00
mtrmac
mtrmac reviewed Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

signature/docker_test.go Outdated Show resolved Hide resolved
@Jamstah Jamstah force-pushed the verify-with-multiple-fingerprints branch from c2236bd to e1680d3 Compare March 31, 2023 11:22
@Jamstah
Copy link
Contributor Author

Jamstah commented Mar 31, 2023

OK, I think its done :)

@TomSweeneyRedHat
Copy link
Member

LGTM

mtrmac
mtrmac approved these changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac mtrmac merged commit 36736c1 into containers:main Apr 1, 2023
@mtrmac mtrmac mentioned this pull request Apr 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jamstah @TomSweeneyRedHat @mtrmac