Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestOCI1IndexChooseInstanceByCompression on non-amd64 #2043

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix TestOCI1IndexChooseInstanceByCompression on non-amd64 #2043

merged 2 commits into from
Jul 18, 2023

Commits on Jul 15, 2023

  1. Fix TestOCI1IndexChooseInstanceByCompression on non-amd64 

    Setting SystemContext.ArchitectureChoice to "" does not mean "match any/the first platform";
it's the default behavior of SystemContext, and it means "choose for the current runtime
architecture". (Originally discussed in
containers#1789 (comment) )

I.e. on amd64 these two test cases are redundant with the first two instances above,
and on other architectures (notably ARM) they cause failures.

So just drop them.

Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    6540d87 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge branch 'main' into aarch64-tests

    @TomSweeneyRedHat
    TomSweeneyRedHat committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    f3807cf View commit details
    Browse the repository at this point in the history