Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint tool handling #2171

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Nov 2, 2023

@TomSweeneyRedHat
Copy link
Member

LGTM
@cevich WDYT?

It isn't actually used anymore.

This might speed up tests a bit.

Signed-off-by: Miloslav Trmač <[email protected]>
... like it does in other repos.

Signed-off-by: Miloslav Trmač <[email protected]>
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking this on.

Hint: Once this is merged, you can force Renovate to "notice" by checking the "trigger renovate to run" box in the dashboard issue.

@cevich
Copy link
Member

cevich commented Nov 3, 2023

(not merging, to allow you to click the renovate button)

@mtrmac mtrmac merged commit 161c5b7 into containers:main Nov 3, 2023
9 checks passed
@mtrmac mtrmac deleted the golangci-lint-update branch November 3, 2023 18:28
@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 3, 2023

Thanks — #2172 was filed, so this seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants