Remove additional check if digester is available #2316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`expectedDigest.Validate()` already calls the `Available()` method and checks if the digest is possible or not. Therefore we can remove the additional/impossible double check for that. Ref: https://github.com/opencontainers/go-digest/blob/429d0316a/digest.go#L111-L116 Signed-off-by: Sascha Grunert <[email protected]>
mtrmac
reviewed
Feb 28, 2024
There was a problem hiding this comment.
You’re right that, as implemented now, this check is redundant.
OTOH Validate() does not document that it checks for availability (and, IMHO, it’s a bit surprising that it does so), and when calling Digester() on an unavailable algorithm panics, I think the extra check here is somewhat warranted.
So I’d prefer keeping the code as is.
|
Sounds good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectedDigest.Validate()already calls theAvailable()method and checks if the digest is possible or not. Therefore we can remove the additional/impossible double check for that.Ref: https://github.com/opencontainers/go-digest/blob/429d0316a/digest.go#L111-L116
Follow-up on #2312