Drop some minimally-used dependencies #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #2365. |
|
LGTM |
rhatdan
reviewed
Apr 5, 2024
oci/layout/oci_delete_test.go
Outdated
| return err | ||
| } | ||
| if _, err := io.Copy(dest, src); err != nil { | ||
| _ = dest.Close() |
There was a problem hiding this comment.
Why not just defer the dest.Close()?
There was a problem hiding this comment.
I didn’t want just defer dest.Close() because a failure in Close after writing could have been significant.
But that’s a good point — doing the error checking in a defer is not actually all that more complex, and better for peace of mind. Fixed.
This is mostly a formality, we still depend on it indirectly. Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to try and decrease our exposure to risk, where it is trivially cheap to do so.
See individual commit messages for details.