Don't abort listing tags when we encounter a digest #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Jun 3, 2024
| // https://github.com/opencontainers/distribution-spec/blob/8a871c8234977df058f1a14e299fe0a673853da2/spec.md?plain=1#L160 , | ||
| // include digests in the list. | ||
| if _, err := digest.Parse(tag); err == nil { | ||
| logrus.Debugf("Ignoring invalid tag %q matching a digest format", tag) |
There was a problem hiding this comment.
This does not appear to be ignoring?
Per containers/skopeo#2346, that happens in the wild. Signed-off-by: Miloslav Trmač <[email protected]>
|
LGTM |
|
Fix confirmed in containers/skopeo#2346 (comment) , for the record. |
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per containers/skopeo#2346, that happens in the wild.