Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stubs to match signature of actual methods #2541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SpangleLabs
Copy link

#2526 has broken building v5.32.2 with the containers_image_fulcio_stub and containers_image_rekor_stub build tags, as the signatures for verifyRekorFulcio() and VerifyRekorSET() were updated without updating the corresponding stubs.

This PR updates the stubs to match

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 27, 2024

Thanks!

First, https://github.com/containers/image/blob/main/CONTRIBUTING.md#sign-your-prs please, we can’t really even look at contributions with unclear copyright status.

@SpangleLabs
Copy link
Author

SpangleLabs commented Nov 6, 2024

So sorry I missed this and then got pulled away to other things and forgot to update it!
I have updated the commit message now, (and rebased) sorry, and thank you! ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants