-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve an error message #2595
Open
mtrmac
wants to merge
1
commit into
containers:main
Choose a base branch
from
mtrmac:error-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve an error message #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Oct 14, 2024
containers/image#2595 will change it. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Oct 14, 2024
Signed-off-by: Miloslav Trmač <[email protected]>
This was referenced Oct 14, 2024
The Skopeo failures should be fixed by containers/skopeo#2442 , that is being tested in containers/skopeo#2441 . |
mtrmac
force-pushed
the
error-text
branch
2 times, most recently
from
October 24, 2024 13:03
a174fb3
to
6afd8b0
Compare
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Oct 25, 2024
containers/image#2595 will change it. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Miloslav Trmač <[email protected]>
We are seeing > reference "[overlay@...]quay.io/...@sha256:..." does not resolve to an image ID: identifier is not an image which is misleading; hide the ErrNoSuchImage text. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing
which is misleading; hide the
ErrNoSuchImage
text.