Special-case an error message to make it clearer #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed in manual testing: # bin/podman --storage-driver vfs pull quay.io/libpod/testimage:20241010
Trying to pull quay.io/libpod/testimage:20241010...
Getting image source signatures
Copying blob a3ed95caeb02 done |
Error: copying system image from manifest list: reading blob sha256:…: partial layer pull is not supported by the graph driver, and fallback is not allowed: not supported |
cgwalters
approved these changes
Oct 18, 2024
vrothberg
reviewed
Oct 18, 2024
mtrmac
force-pushed
the
partial-not-supported
branch
from
5fd9d1b
to
e1d3ad1
Compare
|
Rewritten to just add / improve context. Please review again. Right now, we should see and with containers/storage#2140: |
|
LGTM |
mtrmac
force-pushed
the
partial-not-supported
branch
2 times, most recently
from
03946a8
to
ffaffd6
Compare
- Diferentiate partial pull errors from other read errors - Indicate that this is PrepareStagedLayer that is failing Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
partial-not-supported
branch
from
ffaffd6
to
acaf72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and, also, indirectly, confirm the hypothesis in containers/podman#24308 .