refactor(kubernetes): removed unused displayName property from port forward config
#9806
+125
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR remove the
UserForwardConfiginterface, which were used to add adisplayNameproperty. During the implementation of #9645 I discussed with @jeffmaury, and we decided to keep it without using it (time constraint with release). Then later we should remove it (#9637).As the
UserForwardConfigonly contains thedisplayNameproperty: removing it completely in favour ofForwardConfig.Screenshot / video of UI
What issues does this PR fix or reference?
Part of #9637
All steps available in #9637 (comment)
How to test this PR?