Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman exec --tty resizes only after the process is started #10560

Closed
Luap99 opened this issue Jun 4, 2021 · 2 comments · Fixed by #10683
Closed

podman exec --tty resizes only after the process is started #10560

Luap99 opened this issue Jun 4, 2021 · 2 comments · Fixed by #10683
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@Luap99
Copy link
Member

Luap99 commented Jun 4, 2021

/kind bug

Description

podman exec -it only resizes the terminal after the exec process is started. This issues exists in both local and remote podman.

Steps to reproduce the issue:

  1. podman run -dit --name test alpine top

  2. podman exec -it test stty size

Describe the results you received:
stty: standard input

Describe the results you expected:
two numbers, the real terminal size
19 194
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 4, 2021
@rhatdan
Copy link
Member

rhatdan commented Jun 11, 2021

@Luap99 do you plan on opening a PR for this?

@Luap99
Copy link
Member Author

Luap99 commented Jun 15, 2021

@rhatdan Yes

@Luap99 Luap99 mentioned this issue Jun 15, 2021
Merged
Luap99 added a commit to Luap99/libpod that referenced this issue Jun 16, 2021
@Luap99
Fix resize race with podman exec -it
666f555 
When starting a process with `podman exec -it` the terminal is resized
after the process is started. To fix this allow exec start to accept the
terminal height and width as parameter and let it resize right before
the process is started.

Fixes containers#10560

Signed-off-by: Paul Holzinger <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 24, 2021
@Luap99 @mheon
Fix resize race with podman exec -it
6ba9617 
When starting a process with `podman exec -it` the terminal is resized
after the process is started. To fix this allow exec start to accept the
terminal height and width as parameter and let it resize right before
the process is started.

Fixes containers#10560

Signed-off-by: Paul Holzinger <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix resize race with podman exec -it Luap99/libpod
2 participants
@rhatdan @Luap99