Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS - podman container stats is failing with missing cgroups v2 #11909

Closed
iongion opened this issue Oct 10, 2021 · 3 comments · Fixed by #11919
Closed

MacOS - podman container stats is failing with missing cgroups v2 #11909

iongion opened this issue Oct 10, 2021 · 3 comments · Fixed by #11919
Assignees
@Luap99
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@iongion
Copy link

iongion commented Oct 10, 2021

Context

➜ podman machine list
NAME                     VM TYPE     CREATED      LAST UP
podman-machine-default*  qemu        4 weeks ago  Currently running
➜ podman --version
podman version 3.3.1

podman container stats ID ends with Error: stats is not supported in rootless mode without cgroups v2

But

podman machine ssh podman container stats

Works without an issue, command is missing a remote check.
@mheon mheon added kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Oct 11, 2021
@mheon
Copy link
Member

mheon commented Oct 11, 2021

@jwhonce PTAL

@flouthoc
Copy link
Collaborator

I think the check for unified and rootless needs to be moved away from client to backend.

@Luap99 Luap99 self-assigned this Oct 11, 2021
@Luap99
Copy link
Member

Luap99 commented Oct 11, 2021

I take this one.

@Luap99 Luap99 added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Oct 11, 2021
Luap99 added a commit to Luap99/libpod that referenced this issue Oct 11, 2021
@Luap99
podman stats: move cgroup validation to server
e57b32c 
Podman stats is not supported for rootless cgroupv1 setups. The check
for this must be on the server side and not the client.

[NO NEW TESTS NEEDED] we cannot test this because remote and server are
always on the same machine in CI

Fixes containers#11909

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 mentioned this issue Oct 11, 2021
Merged
mheon pushed a commit to mheon/libpod that referenced this issue Oct 19, 2021
@Luap99 @mheon
podman stats: move cgroup validation to server
fbe9408 
Podman stats is not supported for rootless cgroupv1 setups. The check
for this must be on the server side and not the client.

[NO NEW TESTS NEEDED] we cannot test this because remote and server are
always on the same machine in CI

Fixes containers#11909

Signed-off-by: Paul Holzinger <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

podman stats: move cgroup validation to server Luap99/libpod
4 participants
@iongion @mheon @flouthoc @Luap99