Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support volume "Label" and "Labels" in libpodm but only display "Labels" #12102

Closed
TomSweeneyRedHat opened this issue Oct 26, 2021 · 0 comments · Fixed by #12133
Closed

Support volume "Label" and "Labels" in libpodm but only display "Labels" #12102

TomSweeneyRedHat opened this issue Oct 26, 2021 · 0 comments · Fixed by #12133
Assignees
@jwhonce
Labels
HTTP API Bug is in RESTful API In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@TomSweeneyRedHat
Copy link
Member

A bug was found recently where the "Labels" field displayed in a podman inspect command would show a blank array when it should have instead shown one or more values. A fix was placed into podman-py to handle this, but if it is merged, I think it should eventually be reverted (containers/podman-py#140). It would be better to have libpod handle either Label or Labels and then just send out "Labels". Please see @rhatdan 's comment: containers/podman-py#140 (comment)
@jwhonce jwhonce added HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. labels Oct 27, 2021
@jwhonce jwhonce self-assigned this Oct 27, 2021
@jwhonce jwhonce added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Oct 27, 2021
jwhonce added a commit to jwhonce/podman that referenced this issue Oct 28, 2021
@jwhonce
Allow label and labels when creating volumes
98506c9 
JSON payload may have either key. Labels will override any values set
via Label.

Fixes containers#12102

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce mentioned this issue Oct 28, 2021
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jwhonce jwhonce

Labels
HTTP API Bug is in RESTful API In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow label and labels when creating volumes jwhonce/podman
2 participants
@jwhonce @TomSweeneyRedHat