Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman-remote run --entrypoint "" : fails to override image entrypoint #12521

Closed
edsantiago opened this issue Dec 6, 2021 · 3 comments · Fixed by #12541
Closed

podman-remote run --entrypoint "" : fails to override image entrypoint #12521

edsantiago opened this issue Dec 6, 2021 · 3 comments · Fixed by #12541
Assignees
@flouthoc
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

Looks like a simple corner case:

$ printf "FROM quay.io/libpod/testimage:20210610\nENTRYPOINT ['abc']\n" | bin/podman-remote build -t foo -
STEP 1/2: FROM quay.io/libpod/testimage:20210610
STEP 2/2: ENTRYPOINT ['abc']
COMMIT foo
--> 9222b94e3f3
Successfully tagged localhost/foo:latest
9222b94e3f35032fb5d00b1a2e3934e111ba3bf52f70edbf1e068cfa83849648
$ bin/podman-remote run --entrypoint "" foo date
date: line 1: [abc]: not found

With non-remote podman, this returns the expected date.
@edsantiago edsantiago added the remote Problem is in podman-remote label Dec 6, 2021
edsantiago added a commit to edsantiago/libpod that referenced this issue Dec 6, 2021
@edsantiago
tests: clean up FIXMEs and noise
eee3a42 
e2e tests:
 * remove two FIXMEs:
   * one of them is expected behavior, not a FIXME
   * the other is easily fixed

 * File issue containers#12521 for a real podman-remote bug, and
   update the Skip() message

system tests:
 * in command-completion test, clean up stray podman-pause image
   (followup to containers#12322, in which I missed this instance). This
   removes distracting warnings from test logs.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this issue Dec 6, 2021
Merged
@flouthoc
Copy link
Collaborator

flouthoc commented Dec 7, 2021

I'll check this.

@vrothberg vrothberg added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Dec 7, 2021
@edsantiago
Copy link
Member Author

Thank you. If you find the cause, there's already a test you can un-skip:

podman/test/e2e/run_entrypoint_test.go

Lines 105 to 106 in 9af07fd

It("podman run user entrypoint overrides image entrypoint and image cmd", func() {
SkipIfRemote("#12521: podman-remote not handling passing empty --entrypoint")

@flouthoc flouthoc mentioned this issue Dec 8, 2021
Merged
@flouthoc
Copy link
Collaborator

flouthoc commented Dec 8, 2021

@edsantiago Above PR closes the issues and test is passing.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flouthoc flouthoc

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

specgen: honor empty args for entrypoint specified as --entrypoint "" flouthoc/podman
3 participants
@edsantiago @flouthoc @vrothberg