Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed change to podman machine rm --force #13448

Closed
baude opened this issue Mar 7, 2022 · 2 comments · Fixed by #13466
Closed

Proposed change to podman machine rm --force #13448

baude opened this issue Mar 7, 2022 · 2 comments · Fixed by #13466
Assignees
@baude
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@baude
Copy link
Member

baude commented Mar 7, 2022

I would like to propose a small change to podman machine rm --force. The help text says --force means Do not prompt before rming. I would like to add that --force would stop the machine (it does not today) and remove it without prompts. Would anyone have a conniption fit?
@baude baude added kind/feature Categorizes issue or PR as related to a new feature. 4.1 labels Mar 7, 2022
@baude baude self-assigned this Mar 7, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 7, 2022

No that would seem to be what humans would expect.

@vrothberg
Copy link
Member

SGTM

baude added a commit to baude/podman that referenced this issue Mar 8, 2022
@baude
machine rm -f stops and removes machine
5b51b42 
If you want to remove a running machine, you can now pass the --force/-f
to podman machine rm and the machine will be stopped and removed without
confirmations.

Fixes: containers#13448

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@baude baude mentioned this issue Mar 8, 2022
Merged
tricktron pushed a commit to tricktron/podman that referenced this issue Mar 14, 2022
@baude @tricktron
machine rm -f stops and removes machine
a8e986a 
If you want to remove a running machine, you can now pass the --force/-f
to podman machine rm and the machine will be stopped and removed without
confirmations.

Fixes: containers#13448

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@n1hility n1hility mentioned this issue Mar 18, 2022
Merged
n1hility pushed a commit to n1hility/podman that referenced this issue Mar 18, 2022
@baude @n1hility
machine rm -f stops and removes machine
35b2d95 
If you want to remove a running machine, you can now pass the --force/-f
to podman machine rm and the machine will be stopped and removed without
confirmations.

Fixes: containers#13448

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@baude baude

Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

machine rm -f stops and removes machine baude/podman
3 participants
@rhatdan @baude @vrothberg