Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API build: remote parameter does not work #13831

Closed
matheusfenolio opened this issue Apr 11, 2022 · 5 comments · Fixed by #14254
Closed

API build: remote parameter does not work #13831

matheusfenolio opened this issue Apr 11, 2022 · 5 comments · Fixed by #14254
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@matheusfenolio
Copy link

matheusfenolio commented Apr 11, 2022

I'm trying to build a docker file from my repository, but I'm receiving an error when I call the endpoint curl -X POST http://localhost:8080/v2.0.0/libpod/build?remote=https%3A%2F%2Fgithub.com%2Fmatheusfenolio%2Fpoc

{
	"cause": "stat /var/tmp/libpod_builder4161196413/build/Containerfile: no such file or directory",
	"message": "failed to parse query parameter 'dockerfile': \"Dockerfile\": stat /var/tmp/libpod_builder4161196413/build/Containerfile: no such file or directory",
	"response": 400
}{
	"errorDetail": {
		"message": "stat /var/tmp/libpod_builder4161196413/build/Dockerfile: no such file or directory\n"
	},
	"error": "stat /var/tmp/libpod_builder4161196413/build/Dockerfile: no such file or directory\n"
}

API reference: https://docs.podman.io/en/v3.2.3/_static/api.html#operation/ImageBuildLibpod

@vrothberg vrothberg added the kind/bug Categorizes issue or PR as related to a bug. label Apr 12, 2022
@vrothberg
Copy link
Member

Thanks for reporting, @matheusfenolio !

Looks like the remote parameter does not work as expected. I can reproduce with Podman v4.0.

@vrothberg vrothberg changed the title API: Create new image. API build: remote parameter does not work Apr 12, 2022
@matheusfenolio
Copy link
Author

Thanks! 🙂

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented May 13, 2022

@flouthoc PTAL

flouthoc added a commit to flouthoc/podman that referenced this issue May 16, 2022
Podman API `libpod/build` accepts paramemter `remote` which overrides
`dockerfile` but currently parameter is no-op. Following commit adds
support for `remote` parameter in libpod API.

See: https://docs.podman.io/en/v3.2.3/_static/api.html#operation/ImageBuildLibpod
Closes: containers#13831

Signed-off-by: Aditya R <[email protected]>
@matheusfenolio
Copy link
Author

I built it in Fedora 36, and it's working perfectly!

Thanks all of you for the hard work.

cdoern pushed a commit to cdoern/podman that referenced this issue May 27, 2022
Podman API `libpod/build` accepts paramemter `remote` which overrides
`dockerfile` but currently parameter is no-op. Following commit adds
support for `remote` parameter in libpod API.

See: https://docs.podman.io/en/v3.2.3/_static/api.html#operation/ImageBuildLibpod
Closes: containers#13831

Signed-off-by: Aditya R <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants