Filtering images by label broke in podman-1.3.1

[debarshiray]

/kind bug

This used to work with podman-1.2.0, but doesn't with podman-1.3.1:

$ podman images --filter "label=com.github.debarshiray.toolbox=true"
Error: invalid filter syntax label=com.github.debarshiray.toolbox=true

Output of podman version:

$ podman version
Version:            1.3.1
RemoteAPI Version:  1
Go Version:         go1.11.7
OS/Arch:            linux/amd64

Output of podman info --debug:

debug:
  compiler: gc
  git commit: ""
  go version: go1.11.7
  podman version: 1.3.1
host:
  BuildahVersion: 1.8.2
  Conmon:
    package: podman-1.3.1-1.git7210727.fc29.x86_64
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.12.0-dev, commit: 1347e2d60ece2d99bdf55c16120712a1c6ea34cb'
  Distribution:
    distribution: fedora
    version: "29"
  MemFree: 1638502400
  MemTotal: 8126959616
  OCIRuntime:
    package: runc-1.0.0-85.dev.gitdd22a84.fc29.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc6+dev
      commit: 1d3f73d4086533a858613bc4b6af2b5e882f4730
      spec: 1.0.1-dev
  SwapFree: 4133482496
  SwapTotal: 4133482496
  arch: amd64
  cpus: 4
  hostname: kolache
  kernel: 5.0.9-200.fc29.x86_64
  os: linux
  rootless: true
  uptime: 1h 19m 41.58s (Approximately 0.04 days)
registries:
  blocked: null
  insecure: null
  search:
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.access.redhat.com
  - registry.centos.org
store:
  ConfigFile: /home/rishi/.config/containers/storage.conf
  ContainerStore:
    number: 1
  GraphDriverName: overlay
  GraphOptions:
  - overlay.mount_program=/usr/bin/fuse-overlayfs
  GraphRoot: /home/rishi/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 13
  RunRoot: /run/user/1000
  VolumePath: /home/rishi/.local/share/containers/storage/volumes

[vrothberg]

Hi @debarshiray, thanks for opening the issue. I removed "rootless" from the title as it affects both modes.

[debarshiray]

Thanks @vrothberg

[vrothberg]

Commit 034cc8a introduced the regression. I think it should be a < 2, and we should add some more tests to avoid such regressions in the future. @weirdwiz, can you have a look at that? I will be rushing to the airport in a few minutes.

[juhp]

It would be helpful to see the actual error given by toolbox for this.
With podman-1.3.1-1.git7210727.fc30.x86_64, I get:

$ toolbox -v enter 
toolbox: resolved absolute path for /home/petersen/bin/toolbox to /var/home/petersen/src/toolbox/toolbox
toolbox: checking if /etc/subgid and /etc/subuid have entries for user petersen
toolbox: TOOLBOX_PATH is /var/home/petersen/src/toolbox/toolbox
toolbox: checking if 'podman system migrate' exists
toolbox: migration not needed: 1.3.1 is unchanged
toolbox: Fedora generational core is f30
toolbox: base image is fedora-toolbox:30
toolbox: container is fedora-toolbox-30
toolbox: checking if container fedora-toolbox-30 exists
toolbox: container fedora-toolbox-30 not found
toolbox: container fedora-toolbox-petersen-30 found
toolbox: calling org.freedesktop.Flatpak.SessionHelper.RequestSession
toolbox: trying to start container fedora-toolbox-petersen-30
WARN[0000] no such directory for freezer.state          
WARN[0000] no such directory for freezer.state          
Error: unable to start container "fedora-toolbox-petersen-30": error reading container (probably exited) json message: EOF
toolbox: failed to start container fedora-toolbox-petersen-30

Is that the same issue or am I hitting something else?
(eg my fedora-toolbox-29 and fedora-toolbox-petersen-31 containers still run fine, but I need to revert to podman-1.2 for my fedora-toolbox-petersen-30 to work.)
Otherwise I should open another issue for this: if you need more info please reply sooner than later, since I probably a new fedora-toolbox-30 container soon...).

edit: I filed issue 3219 for this.

[debarshiray]

Is that the same issue or am I hitting something else?

I think yours is a different issue.