-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reminder: rootless, rawhide: spurious warnings #4456
Comments
Why are we printing warning messages again? I remember fixing that. |
I think it's the code in the We should investigate moving it into |
I suggest removing the config generation entirely, see #4457. |
Do not generate an entire `config.Config` for displaying the default value for the --cgroup-manager flag and just default to systemd. Not using the `config.Config` is okay as 1) the value may change at runtime in any case (rootless, DBUS access, etc.), 2) it avoids to redundantly parse the system config files and to generate the hard-coded default config, and 3) the log-level and other attributes are not yet set during init() causing undesirable side effects. Fixes: containers#4456 Signed-off-by: Valentin Rothberg <[email protected]>
Followup: #4457 seems to have fixed the spurious warning messages, thank you. But gating tests are now failing rootless with:
It'll take me a little while to look into it; am commenting simply in case it elicits an "aha" in anyone. |
Great, happy we could tackle it so quickly!
@edsantiago did this work before? I think we have two options: 1) force the gating tests to use |
Before what? :-/ Gating tests were passing in 1e750f7, October 31, and I'm pretty sure that was with crun. |
@edsantiago, the error message indicates that we're running |
Do not generate an entire `config.Config` for displaying the default value for the --cgroup-manager flag and just default to systemd. Not using the `config.Config` is okay as 1) the value may change at runtime in any case (rootless, DBUS access, etc.), 2) it avoids to redundantly parse the system config files and to generate the hard-coded default config, and 3) the log-level and other attributes are not yet set during init() causing undesirable side effects. Fixes: containers#4456 Signed-off-by: Valentin Rothberg <[email protected]>
Just a reminder that gating tests are broken for rootless on rawhide due to spurious warning messages:
It seems possible that this is an unintended side effect of #4352. This is something for @vrothberg to look at once he's back. I'm filing issue so it doesn't get forgotten.
First build showing this problem: ca4c24c
The text was updated successfully, but these errors were encountered: