Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect command: Populate Bridge field in network settings #6618

Closed
drewbailey opened this issue Jun 16, 2020 · 11 comments
Closed

inspect command: Populate Bridge field in network settings #6618

drewbailey opened this issue Jun 16, 2020 · 11 comments
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@drewbailey
Copy link

/kind feature

Populate bridge field in network settings when applicable

Steps to reproduce the issue:

  1. sudo podman run -m=40m -p 8080:89 --network=bridge redis

  2. sudo podman inspect <container>

Describe the results you received:

    "NetworkSettings": {
      "EndpointID": "",
      "Gateway": "10.88.0.1",
      "IPAddress": "10.88.0.239",
      "IPPrefixLen": 16,
      "IPv6Gateway": "",
      "GlobalIPv6Address": "",
      "GlobalIPv6PrefixLen": 0,
      "MacAddress": "62:86:4f:c2:28:01",
      "Bridge": "",
      "SandboxID": "",
      "HairpinMode": false,
      "LinkLocalIPv6Address": "",
      "LinkLocalIPv6PrefixLen": 0,
      "Ports": [
        {
          "hostPort": 8080,
          "containerPort": 89,
          "protocol": "tcp",
          "hostIP": ""
        }
      ],
      "SandboxKey": "/var/run/netns/cni-5ada0c78-0a5f-ea18-a950-7141c110f46b"
    },

Describe the results you expected:

Bridge to be populated with the cni id of the bridge in use

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

→ podman version
Version:            1.9.3
RemoteAPI Version:  1
Go Version:         go1.13.8
OS/Arch:            linux/amd64

Output of podman info --debug:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman):

(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 16, 2020
@QiWang19
Copy link
Contributor

Do you mean there should be Network field Under "NetworkSettings"?

"Networks": {
                "bridge": {
                    "IPAMConfig": null,
                    "Links": null,
                    "Aliases": null,
                    "NetworkID": "0df86146427ffaaf905bee17342ed31d012d761fc34a8788584427f53e1ac99b",
                    "EndpointID": "bd120b2e6fd090dbb180342956f9daa440ea5a3db78466dc1ed19bf3ba197dfd",
                    "Gateway": "172.17.0.1",
                    "IPAddress": "172.17.0.2",
                    "IPPrefixLen": 16,
                    "IPv6Gateway": "",
                    "GlobalIPv6Address": "",
                    "GlobalIPv6PrefixLen": 0,
                    "MacAddress": "02:42:ac:11:00:02",
                    "DriverOpts": null
                }
            }

@mheon
Copy link
Member

mheon commented Jun 24, 2020

No - that looks like the output of a network from podman network create - this is about populating the name of the CNI network that is being used by default, I believe

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jul 25, 2020

@QiWang19 @mheon What is the scoop on this issue?

@mheon
Copy link
Member

mheon commented Jul 25, 2020 via email

@rhatdan rhatdan added Good First Issue This issue would be a good issue for a first time contributor to undertake. and removed stale-issue labels Dec 24, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 24, 2020

Know one has worked on this, and it is still an issue. (At least I verified the bug using the repeater above).

@containers/podman-maintainers Anyone want to take a look?

@rhatdan
Copy link
Member

rhatdan commented Dec 24, 2020

@baude do you have time for this?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jan 25, 2021

Still an issue.

@rhatdan
Copy link
Member

rhatdan commented Jan 25, 2021

@mheon Any chance you can work on this?

@baude
Copy link
Member

baude commented Jan 25, 2021

I can peek at it ...

@baude baude added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Jan 25, 2021
baude added a commit to baude/podman that referenced this issue Jan 25, 2021
when inspecting a container that is only connected to the default
network, we should populate the default network in the container inspect
information.

Fixes: containers#6618

Signed-off-by: baude <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Jan 29, 2021
when inspecting a container that is only connected to the default
network, we should populate the default network in the container inspect
information.

Fixes: containers#6618

Signed-off-by: baude <[email protected]>

MH: Small fixes, added another test

Signed-off-by: Matthew Heon <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants