Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support container-to-container copy #7370

Closed
daiaji opened this issue Aug 19, 2020 · 20 comments · Fixed by #11049
Closed

support container-to-container copy #7370

daiaji opened this issue Aug 19, 2020 · 20 comments · Fixed by #11049
Assignees
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@daiaji
Copy link

daiaji commented Aug 19, 2020

podman cp v2ray:/etc/ssl/certs/ca-certificates.crt caddy:/etc/ssl/certs/ca-certificates.crt
Error: invalid arguments v2ray:/etc/ssl/certs/ca-certificates.crt, caddy:/etc/ssl/certs/ca-certificates.crt you must use just one container

There seems to be no harm in implementing this function.

@zhangguanzhang
Copy link
Collaborator

which version did you used to? or , did you tried with the latest version?

@mheon
Copy link
Member

mheon commented Aug 19, 2020

Should be technically possible. I'll label this as a feature request.

@mheon mheon added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 19, 2020
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Nov 25, 2020

@vrothberg Is working on podman-remote cp now, so maybe he can look at this?

@vrothberg
Copy link
Member

@vrothberg Is working on podman-remote cp now, so maybe he can look at this?

Good timing. I am currently rewiring the entire copy code. I will keep this in mind so that we can easily add support for container-to-container copy.

@vrothberg vrothberg changed the title Why doesn't cp allow copying files between containers? support container-to-container copy Nov 26, 2020
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Dec 28, 2020

@vrothberg Did you make this work?

@vrothberg
Copy link
Member

@vrothberg Did you make this work?

No. I focused on host/ctr copying only. The backend code, however, would allow that now, so that (nearly) all code changes would happen cmd/podman.

@rhatdan rhatdan assigned QiWang19 and unassigned QiWang19 and vrothberg Feb 3, 2021
@rhatdan
Copy link
Member

rhatdan commented Feb 3, 2021

Since this is a feature, we can put it off for a while until we stabilize 3.0

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan rhatdan added Good First Issue This issue would be a good issue for a first time contributor to undertake. and removed stale-issue labels Mar 27, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2021

This would still be a good feature. I was recently asked about this in buildah copy as well, but in that case they wanted to copy from an image to a container.

@vrothberg
Copy link
Member

Agreed, it would be really nice to get this done. I have too many things on my plate at the moment but I'd be more than happy to help others get it done. A word of caution: I do not think it's a good first issue. It will require very extensive testing.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@infiniteregrets
Copy link

hey @vrothberg, are you working on this? If not then, can I try working on it

@vrothberg vrothberg added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Jun 17, 2021
@vrothberg
Copy link
Member

vrothberg commented Jun 17, 2021

hey @vrothberg, are you working on this? If not then, can I try working on it

Thanks, it's yours :)

As mentioned above, this feature will need extensive testing in https://github.com/containers/podman/blob/master/test/system/065-cp.bats but we can assist. Code wise, the plumbing would happen cmd/podman/containers/cp.go.

@infiniteregrets
Copy link

I will try to work on it as soon as possible. I will ping you if I am stuck! Thank you

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jul 19, 2021

@infiniteregrets @vrothberg Did this ever move forward?

@infiniteregrets
Copy link

infiniteregrets commented Jul 19, 2021

@rhatdan I did move it forward, but I couldnt figure out how to rename a file which does not exist in the destination when copied, so @vrothberg will take over. sorry ):

@vrothberg
Copy link
Member

I plan to tackle it this week 👍

@vrothberg vrothberg removed the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Jul 26, 2021
vrothberg pushed a commit to vrothberg/libpod that referenced this issue Jul 27, 2021
Implement container to container copy.  Previously data could only be
copied from/to the host.

Fixes: containers#7370
Co-authored-by: Mehul Arora <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants