-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sporadic resize tty warnings when running containers with podman 3.0 #9172
Comments
Happy path:
Sad path:
|
Opened #9217 to address the warning, thanks @afbjorklund ! |
No worries, hope that you can get it fixed before the release. $ podman3-remote run --rm -it busybox true
$ podman3-remote run --rm -it busybox true
$ podman3-remote run --rm -it busybox true
WARN[0000] failed to resize TTY: <nil>
$ podman3-remote run --rm -it busybox true
$ podman3-remote run --rm -it busybox true
WARN[0000] failed to resize TTY: <nil>
$ podman3-remote run --rm -it busybox true
$ podman3-remote run --rm -it busybox true
$ podman3-remote run --rm -it busybox true
$ podman3-remote run --rm -it busybox true
|
I think @vrothberg accidentally said the magic word (as in: does not fix) /reopen |
@afbjorklund: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@afbjorklund Could you try again against the main branch? To see if we get more info. |
The resize warning logged the wrong error. While this does not fix containers#9172, it may very well be helpful finding its root cause. [NO TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
Yes, now the error looks much "better" now on podman master (b1bd126): $ ./bin/podman-remote run --rm -it busybox true
WARN[0000] failed to resize TTY: container "a1e1c4631e8a113221559ca0e851c210c2a36724f7ca2fe087d5f866701f09fe" in wrong state "created"
$ ./bin/podman-remote run --rm -it busybox true
$ ./bin/podman-remote run --rm -it busybox true
$ ./bin/podman-remote run --rm -it busybox true
WARN[0000] failed to resize TTY: container "e5df1faf8c5e6e52ac49a2a52a582c9e803e5ccc98961c601a320b3875d7ca29" in wrong state "created"
$ ./bin/podman-remote run --rm -it busybox true
WARN[0000] failed to resize TTY: container "dcc7b50dc95cd9f6f1daf462fb7f432312a1f431e644d41e76b902ce41a481db" in wrong state "created"
$ ./bin/podman-remote run --rm -it busybox true
WARN[0000] failed to resize TTY: container "4ab79eb9dddaa8573f48da894e061fbc66ff994b70879aaf60b2ae5dea062c38" in wrong state "created"
$ ./bin/podman-remote run --rm -it busybox true
WARN[0000] failed to resize TTY: container "f763a9d4d8a5de8a23e757992222b667823316acd169f081681efdc5e87db3ee" in wrong state "created"
$ ./bin/podman-remote run --rm -it busybox true
WARN[0000] failed to resize TTY: container "33037fe9106776da9225fb523eee71d3578976fd2128fda029789f97c9fed8a4" in wrong state "created"
$ ./bin/podman-remote run --rm -it busybox true
$ ./bin/podman-remote run --rm -it busybox true Just running towards a local server, so shouldn't be about network issues. |
Thanks for checking, @afbjorklund! This smells like a race in the remote client. Resizing a "stopped" container won't work :) |
Reliving old Docker bugs... It used to ignore WINCH signals, had to run |
Also experiencing this almost 100% of the times, not always. podman version 3.0.1 |
Should we just drop this down in lever from WARN, if the user can not do something about it, and we don't feel that it is an error, then we should not Warn the user. |
I'm not sure it has any major user impact, but there is a race somewhere in the startup. $ podman-remote run -it fedora stty size
140 42
$ podman-remote run -it fedora stty size
140 42
$ podman-remote run -it fedora stty size
140 42
$ podman-remote run -it fedora stty size
WARN[0000] failed to resize TTY: container "92a332cce3ac39307e6fd74cc6f26fadaa6ee63d211967c542e04e0b343909cb" in wrong state "created"
0 0
$ podman-remote run -it fedora stty size
140 42
$ podman-remote run -it fedora stty size
140 42
$ podman-remote run -it fedora stty size
140 42
|
Yes - this is a real bug. If the warning fires, we have a bad TTY size set. |
Not directly related to the sporadic error reported here, but I am new to container and first time using podman client and people seems to know a lot on tty related things in this discurrion. To me, it looks like row/columns is inverted on the podman client. i.e. using podman client, in the container, stty size reports 364 17, but if I ssh to the remote host and use the local podman, stty size reports 17 364. which might explains the weird line wrapping I am seeing on first try of podman client. |
Can you open a separate issue for that? It sounds properly strange. |
Ok. Opened #9756 |
I didn't even look at the numbers, to see that they were actually flipped :-D
Just compared them with |
Did someone open a PR to fix this? |
It seems to still be there with v3.1.0-rc2, like 33% of the time or so. |
A friendly reminder that this issue had no activity for 30 days. |
@afbjorklund Could you check if we still have this issue? |
The WARNING no longer shows up, but the issue still happens sporatically.
|
A friendly reminder that this issue had no activity for 30 days. |
I just ran over 300 tests and can not get this to happen with current main branch so I am going to close. |
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
Sporadic error output, when running containers.
Steps to reproduce the issue:
podman-remote run -it busybox true
Describe the results you received:
WARN[0000] failed to resize TTY: <nil>
Describe the results you expected:
Additional information you deem important (e.g. issue happens only occasionally):
Only happens occasionally. Seems to be a race between running and resizing ?
Didn't see this with podman2.
Note that the original error is wrong, due to dumping the wrong error variable.
The real error is:
WARN[0000] failed to resize TTY: container "909607af8e848d82382b7d9a08e53d28c326d16e0229d62bdb9b3cfe5d7fb188" in wrong state "created"
Output of
podman version
:Output of
podman info --debug
:Package info (e.g. output of
rpm -q podman
orapt list podman
):Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide?
Yes
Additional environment details (AWS, VirtualBox, physical, etc.):
Ubuntu
The text was updated successfully, but these errors were encountered: