Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race: podman-remote run -it : stty: standard input #9859

Closed
edsantiago opened this issue Mar 29, 2021 · 5 comments · Fixed by #10549
Closed

race: podman-remote run -it : stty: standard input #9859

edsantiago opened this issue Mar 29, 2021 · 5 comments · Fixed by #10549
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

edsantiago commented Mar 29, 2021 •
edited
Loading

Almost certainly related to #9831 / #9833

In window 1:

$ ./bin/podman system service --timeout=0

In window 2:

$ ./bin/podman-remote run -it --rm quay.io/libpod/testimage:20210223 stty size
stty: standard input
WARN[0000] Container 980c16fd4dd648821d6a1029f1d93a52f380250e4e516fc10c2c311c7caf25d9 does not exist: no container with name or ID "980c16fd4dd648821d6a1029f1d93a52f380250e4e516fc10c2c311c7caf25d9" found: no such container

The "Container does not exist" warning is correlated with --rm.

Once in a while, the stty will succeed:

$ ./bin/podman-remote run -it quay.io/libpod/testimage:20210223 stty size
60 160

[UPDATED 2021-03-29 because I forgot to mention the workaround]
Workaround: add a sleep:

$ ./bin/podman-remote run -it --rm quay.io/libpod/testimage:20210223 sh -c 'sleep 1;stty size'
60 160
@edsantiago edsantiago added flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Mar 29, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2021

You saw this post my PR getting merged?

@edsantiago
Copy link
Member Author

Yes, in fact you deliberately re-added the sleep to your PR to get it to pass CI, because this bug was still present despite your PR.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

still present in 4ca34fc

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@Luap99 Luap99 mentioned this issue Jun 3, 2021
Merged
Luap99 added a commit to Luap99/libpod that referenced this issue Jun 4, 2021
@Luap99
remote: always send resize before the container starts
1f73374 
There is race condition in the remote client attach logic. Because the
resize api call was handled in an extra goroutine the container was
started before the resize call happend. To fix this we have to call
resize in the same goroutine as attach. When the first resize is done
start a goroutine to listen on SIGWINCH in the background and resize
again if the signal is received.

Fixes containers#9859

Signed-off-by: Paul Holzinger <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 11, 2021
@Luap99 @mheon
remote: always send resize before the container starts
26eae3b 
There is race condition in the remote client attach logic. Because the
resize api call was handled in an extra goroutine the container was
started before the resize call happend. To fix this we have to call
resize in the same goroutine as attach. When the first resize is done
start a goroutine to listen on SIGWINCH in the background and resize
again if the signal is received.

Fixes containers#9859

Signed-off-by: Paul Holzinger <[email protected]>

<MH: Fixed cherry-pick conflicts>

Signed-off-by: Matthew Heon <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remote: always send resize before the container starts Luap99/libpod
2 participants
@edsantiago @rhatdan