Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/bindings/images.nTar(): set ownership of build context to 0:0 #11473

Merged
merged 1 commit into from
Sep 8, 2021
Merged

pkg/bindings/images.nTar(): set ownership of build context to 0:0 #11473

merged 1 commit into from
Sep 8, 2021

Commits on Sep 7, 2021

  1. pkg/bindings/images.nTar(): set ownership of build context to 0:0 

    When attempting to run remote builds, users with UID/GID values that
were high enough that they wouldn't be mapped into their default user
namespace configurations would see their builds fail when the server
attempted to extract the build contexts that they supplied, and failed
to set ownership of the build context content to the UID/GID that were
originally assigned to them.

When archiving the build context at the client, set ownership of
everything to 0:0, which we know is always mapped.  Both ADD and COPY
require that we set the ownership of newly-added content to 0:0 (unless
the --chown flag is used), so throwing away the original ownership
information doesn't hurt, anyway.  As usual, tarballs that we extract
as part of ADD aren't going to be affected.

Signed-off-by: Nalin Dahyabhai <[email protected]>
    @nalind
    nalind committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    748c270 View commit details
    Browse the repository at this point in the history