Pod Events Logging Fix #11816
Merged
Pod Events Logging Fix #11816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheon
reviewed
Sep 30, 2021
cdoern
force-pushed
the
podEventsBug
branch
from
f11ca78
to
a24a8f4
Compare
|
@containers/podman-maintainers PTAL, This slipped by when redesigning infra. Glad we could catch it now. |
Luap99
requested changes
Sep 30, 2021
cdoern
force-pushed
the
podEventsBug
branch
from
a24a8f4
to
29dfa28
Compare
cdoern
force-pushed
the
podEventsBug
branch
2 times, most recently
from
f064339
to
89ac079
Compare
vrothberg
reviewed
Oct 1, 2021
Luap99
reviewed
Oct 1, 2021
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
on create, libpod was only creating a new event if the pod had an infra container. now, pod creation triggers a new pod event with or without infra Signed-off-by: cdoern <[email protected]>
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on create, libpod was only creating a new event if the pod had an infra container.
now, pod creation triggers a new pod event with or without infra.
Signed-off-by: cdoern [email protected]