Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpod: fix race when closing STDIN #11864

Merged
merged 1 commit into from
Oct 6, 2021
Merged

libpod: fix race when closing STDIN #11864

merged 1 commit into from
Oct 6, 2021

Commits on Oct 6, 2021

  1. libpod: fix race when closing STDIN 

    There is a race where `conn.Close()` was called before `conn.CloseWrite()`.
In this case `CloseWrite` will fail and an useless error is printed. To
fix this we move the the `CloseWrite()` call to the same goroutine to
remove the race. This ensures that `CloseWrite()` is called before
`Close()` and never afterwards.
Also fixed podman-remote run where the STDIN was never was closed.
This is causing flakes in CI testing.

[NO TESTS NEEDED]

Fixes containers#11856

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99
    Luap99 committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    fbce758 View commit details
    Browse the repository at this point in the history