Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11728 Remove gvproxy listen argument #12190

Closed
wants to merge 1 commit into from
Closed

Fixes #11728 Remove gvproxy listen argument #12190

wants to merge 1 commit into from

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Nov 6, 2021

Signed-off-by: Gábor Lipták [email protected]

What this PR does / why we need it:

#11728

How to verify it

Which issue(s) this PR fixes:

Fixes #11728

*** Please also put 'Fixes #' in the commit and PR description***

-->

Special notes for your reviewer:

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gliptak
To complete the pull request process, please assign mheon after the PR has been reviewed.
You can assign the PR to them by writing /assign @mheon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Nov 6, 2021

Thanks @gliptak
Could you add a little more information to your commit to explain that this is no longer needed. Also add
[NO NEW TEST NEEDED] to make the tests happy.
LGTM

@gliptak
Copy link
Contributor Author

gliptak commented Nov 6, 2021

@rhatdan thank you for the pointers. How would an "integration" test look to cover this?

Fixes #11728

Podman machine CNI plugin to directly talk to the forwarder service without
having to expose the gvproxy API on a port. It removes the port 7777 used
by podman machine.

[NO NEW TESTS NEEDED]

Signed-off-by: Gábor Lipták <[email protected]>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot change this until we also changed the podman-machine-cni plugin do use the new address.

@Luap99
Copy link
Member

Luap99 commented Nov 8, 2021

It does not make sense to change this in the podman-machine-cni repo because I plan to move the code into podman to fix a variety of issues.
Hopefully I get this done this week.

@Luap99
Copy link
Member

Luap99 commented Nov 12, 2021

Replaced by #12283

@Luap99 Luap99 closed this Nov 12, 2021
@gliptak gliptak deleted the gvproxy1 branch November 13, 2021 00:39
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustable machine proxy port
3 participants