e2e: fix pprof flakes #12518
e2e: fix pprof flakes #12518
Conversation
Give the services some more time after SIGINT to shutdown. `Eventually(session, 5)` will poll the session for the specific condition at a frequency of 10ms for at most 5 seconds. Fixes: containers#12167 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@edsantiago, I am positive that will cure the flake but I am never fully satisfied with bumping timeouts. At least the polling will avoid waiting entire 5 seconds. |
|
Seems worth a try. Thanks @vrothberg . |
|
I should mention that eventually waits 1 second by default. |
|
I know: this gomega ref has been stickied in my browser for the last two weeks (due to all my e2e test work), and I checked it before commenting! |
|
@containers/podman-maintainers PTAL |
|
LGTM |
|
/lgtm |
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
edsantiago
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Give the services some more time after SIGINT to shutdown.
Eventually(session, 5)will poll the session for the specificcondition at a frequency of 10ms for at most 5 seconds.
Fixes: #12167
Signed-off-by: Valentin Rothberg [email protected]