overlay-volumes: add support for non-volatile upperdir,workdir for overlay volumes
#14474
Conversation
openshift-ci
bot
added
release-note
approved
flouthoc
force-pushed
the
non-volatile-overlay-volume
branch
from
841b471
to
7571cd5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flouthoc
force-pushed
the
non-volatile-overlay-volume
branch
2 times, most recently
from
29e9ccb
to
5676710
Compare
flouthoc
force-pushed
the
non-volatile-overlay-volume
branch
from
5676710
to
e58c588
Compare
flouthoc
force-pushed
the
non-volatile-overlay-volume
branch
from
e58c588
to
3081bfa
Compare
|
LGTM |
flouthoc
force-pushed
the
non-volatile-overlay-volume
branch
from
3081bfa
to
a4bdcf5
Compare
|
Is "anonymous volume" an overlayfs term I'm not familiar with? Because these are not anonymous volumes in the Podman sense (which are created at container create time and do not specify any details about where the volume is to be mounted from). Calling this just an "overlay volume" seems more appropriate? |
Yeah we can just call it |
…onymous volumes Similar feature was added for named overlay volumes here: containers#12712 Following PR just mimics similar feature for anonymous volumes. Often users want their anonymous overlayed volumes to be `non-volatile` in nature that means that same `upper` dir can be re-used by one or more containers but overall of nature of volumes still have to be overlay so work done is still on a overlay not on the actual volume. Following PR adds support for more advanced options i.e custom `workdir` and `upperdir` for overlayed volumes. So that users can re-use `workdir` and `upperdir` across new containers as well. Usage ```console podman run -it -v /some/path:/data:O,upperdir=/path/persistant/upper,workdir=/path/persistant/work alpine sh ``` Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
non-volatile-overlay-volume
branch
from
a4bdcf5
to
aadae49
Compare
flouthoc
changed the title
upperdir,workdir for anonymous volumesupperdir,workdir for overlay volumes
|
Happy green test buttons. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Similar feature was added for
namedoverlay volumes here: #12712Following PR just mimics similar feature for anonymous volumes.
Often users want their anonymous overlayed volumes to be
non-volatilein naturethat means that same
upperdir can be re-used by one or morecontainers but overall of nature of volumes still have to be overlay
so work done is still on a overlay not on the actual volume.
Following PR adds support for more advanced options i.e custom
workdirand
upperdirfor overlayed volumes. So that users can re-useworkdirand
upperdiracross new containers as well.Usage
podman run -it -v /some/path:/data:O,upperdir=/path/persistant/upper,workdir=/path/persistant/work alpine shDoes this PR introduce a user-facing change?
Closes: #14427