-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-running containers now report statistics via the podman stats
#14580
Non-running containers now report statistics via the podman stats
#14580
Conversation
LGTM |
20dd0ac
to
f0c70a1
Compare
LGTM |
/approve |
Looks like tests need to be fixed. |
command Previously, if a container was not running, and the user ran the `podman stats` command, an error would be reported: `Error: container state improper`. Podman now reports stats as the fields' default values for their respective type if the container is not running: ``` $ podman stats --no-stream demo ID NAME CPU % MEM USAGE / LIMIT MEM % NET IO BLOCK IO PIDS CPU TIME AVG CPU % 4b4bf8ce84ed demo 0.00% 0B / 0B 0.00% 0B / 0B 0B / 0B 0 0s 0.00% ``` Closes: containers#14498 Signed-off-by: Jake Correnti <[email protected]>
f0c70a1
to
608ad7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, jakecorrenti, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
command
Previously, if a container was not running, and the user ran the
podman stats
command, an error would be reported:Podman now reports stats as the fields' default values for their
respective type if the container is not running:
Closes: #14498
Signed-off-by: Jake Correnti [email protected]
Does this PR introduce a user-facing change?