fixes data race in system.Events and nil error logging

[thediveo]

[NO NEW TESTS NEEDED]

None

[rhatdan]

Please repush, since I added the [NO NEW TESTS NEEDED] flag.

[rhatdan]

LGTM
@Luap99 @mheon PTAL

[rhatdan]

Thanks @thediveo

[mheon]

/lgtm
/hold

[rhatdan]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, thediveo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[thediveo]

just out of curiosity to better understand the processes: what's the "hold"?

[Luap99]

just out of curiosity to better understand the processes: what's the "hold"?

If test are still running or are red (failing) we use the hold to make sure this PR does not end up in the merge queue. While the merge bot will only merge the PR once all tests are green, it will for some reason still put it in the merge queue. The bot will merge PR in the same order as their are in the queue which means that no other PR can be merged in the meantime until this one was merged which can take a while due failing test.

The hold will prevent us from having this problem. You can safely remove the hold once all tests are green until someone says otherwise.

[thediveo]

ah, thank you very much for the explanation!

Re the failing checks, I'm unclear if the exact fails are even related to my small change:

 not ok 324 sensitive mount points are masked without --privileged

How to move this forward?

[Luap99]

ah, thank you very much for the explanation!

Re the failing checks, I'm unclear if the exact fails are even related to my small change:

 not ok 324 sensitive mount points are masked without --privileged

How to move this forward?

I click rerun on the test. Basically we have a ton of test which fail (flake) randomly.

[Luap99]

/hold cancel