-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix restore API endpoint #15909
fix restore API endpoint #15909
Conversation
restore endpoint was totally ignoring --pod, it was missing from the schema and from query handling on the api handlers side. add support for it here. resolves containers#15018 Signed-off-by: cdoern <[email protected]>
LGTM But are you sure tests are running. Shouldn't the --pod test have failed on non Ubuntu platforms in remote mode? |
@cdoern ping |
sorry, will get to this in the afternoon today |
@rhatdan tests are running ... but : cc/ @edsantiago |
Sorry... I don't understand the question. I see green CI, no failures? IIRC the context behind this was that we were using |
@edsantiago I'm forgetting, are we testing runc with fedora too? Because if so, this test is not being executed with runc since it was green before this PR |
There is no testing of |
Alright that's what I assumed, just wanted to check. In that case @rhatdan @vrothberg I think this is all set |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
restore endpoint was totally ignoring --pod, it was missing from the schema and from query handling on the api handlers side. add support for it here.
resolves #15018
Signed-off-by: cdoern [email protected]
Does this PR introduce a user-facing change?