Fix test flakes caused by improper podman-logs #16435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one has been a thorn in my side: it's a podman-log issue, but not remote, so I _almost_ retitled containers#16132 (removing "remote"). Nope, it's a bug in the tests themselves. One solution would be to podman-wait, but I see no reason for logs to be involved, so I went with podman start -a instead. This removes the k8s-log stuff which is no longer necessary. Cleanup all around. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
added
the
kind/test-flake
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
/hold cancel I think this serves as a belated confirmation of #16401 : tests were skipped, but Windows didn't fail. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Nice catch, @edsantiago ! |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one has been a thorn in my side: it's a podman-log issue, but not remote, so I almost retitled #16132 (removing "remote").
Nope, it's a bug in the tests themselves. One solution would be to podman-wait, but I see no reason for logs to be involved, so I went with podman start -a instead. This removes the k8s-log stuff which is no longer necessary. Cleanup all around.
Signed-off-by: Ed Santiago [email protected]