fix(env): parsing --env incorrect in cli

[BlackHole1]

Fixed: #19096 (comment)
Fixed: #19096 (comment)

The root cause of this issue lies in the fact that the shell discards the quotes in the parameters, as shown in the following code snippet:

podman run -e K='a#b' alpine printenv aaa
# To
podman run -e K=a#b alpine printenv aaa

This will result in problems with the current parseEnv implementation. Unfortunately, there is no way to change the behavior of the shell, so the only option is to fix it within parseEnv. In order to reduce code complexity, I have ported the previous parseEnv function back and renamed it as parseEnvWithSlice. Furthermore, this function will be used exclusively for the --env option, which will bring another benefit: it will run faster than --env-file.

Now:

$ podman run --env aaa='aaa\nbbb#ccc\nddd' alpine printenv aaa
aaa\nbbb#ccc\nddd

Does this PR introduce a user-facing change?

Fix the issue where the parsing of the `--env` parameter value is incorrect.

---

Ref:

1. pass json string as flag remove double quotes spf13/cobra#898
2. https://stackoverflow.com/questions/53896081/how-to-keep-quotes-in-os-args
3. os.Args is missing/eating/interpreting double quote on Windows golang/go#30952

PTAL @rhatdan @vrothberg @Luap99
/cc @edsantiago @kajinamit

[openshift-ci]

@BlackHole1: GitHub didn't allow me to request PR reviews from the following users: kajinamit.

Note that only containers members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixed: #19096 (comment)
Fixed: #19096 (comment)

The root cause of this issue lies in the fact that the shell discards the quotes in the parameters, as shown in the following code snippet:

podman run -e K='a#b' alpine printenv aaa
# To
podman run -e K=a#b alpine printenv aaa

This will result in problems with the current parseEnv implementation. Unfortunately, there is no way to change the behavior of the shell, so the only option is to fix it within parseEnv. In order to reduce code complexity, I have ported the previous parseEnv function back and renamed it as parseEnvWithSlice. Furthermore, this function will be used exclusively for the --env option, which will bring another benefit: it will run faster than --env-file.

Does this PR introduce a user-facing change?

Fix the issue where the parsing of the `--env` parameter value is incorrect.

---

Ref:

1. pass json string as flag remove double quotes spf13/cobra#898
2. https://stackoverflow.com/questions/53896081/how-to-keep-quotes-in-os-args
3. os.Args is missing/eating/interpreting double quote on Windows golang/go#30952

PTAL @rhatdan @vrothberg @Luap99
/cc @edsantiago @kajinamit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BlackHole1]

@vrothberg Thank you for your CR. I modified done.

[vrothberg]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlackHole1, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm
/hold
@BlackHole1 PTAL

[BlackHole1]

/lgtm /hold @BlackHole1 PTAL

@rhatdan Are you pinging the wrong person? 🤣

[rhatdan]

Yes. I meant to ping the reporter of the bug.
/hold cancel

[TomSweeneyRedHat]

I'm going to backport this to the 4.6 branch.

[edsantiago]

I don't think the original env-file PR made it into 4.6

[edsantiago]

I'm upset that this got merged without my review. There are still problems with env-file processing. I will open up new issues.

[TomSweeneyRedHat]

Just noting for future reference, that if this fix is backported into Podman 4.4, it has the potential to break OpenStack on that version of RHEL (9.2). Please do NOT backport this to the 4.4 branch without very careful consideration. Please note: https://bugzilla.redhat.com/show_bug.cgi?id=2230212 for details.

[kajinamit]

What breaks OpenStack(actually it does not break the whole OpenStack but only TripleO which is the deployment tool) is not this one but #19096 , thought as long as that is backported along with this follow-up PR then it would not cause problem with the usage in RHEL9.2 .