Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make --seccomp=profile.json clearer #21545

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Feb 7, 2024

There are not only allowed syscalls, also blocked ones or handled differently.

[CI:DOCS]

Does this PR introduce a user-facing change?

None

There are not only allowed syscalls, also blocked ones or handled
differently.

[CI:DOCS]

Signed-off-by: Giuseppe Scrivano <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2024
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Feb 7, 2024

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
Copy link

Cockpit tests failed for commit 77847bd. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

@giuseppe @Luap99 @vrothberg Something major just broke in rawhide a few hours ago, which completely breaks cockpit, in all projects (not just c-podman). We are investigating. For urgent stuff, please ignore rawhide-cockpit-revdeps run and just look at f39.

@martinpitt
Copy link
Contributor

OK, that selinux-policy rawhide update broke cockpit hard, but the emergency update fixed it. Can you please go through the cockpit-revdeps rawhide failures in https://github.com/containers/podman/pulls and retry these? there should be at least 7 of them. I'm not allowed to retry them myself. Thanks, and sorry for the noise!

@Luap99
Copy link
Member

Luap99 commented Feb 8, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a613f07 into containers:main Feb 8, 2024
87 of 89 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 9, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants