Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpod/image: Use RepoDigests() in Inspect() #2251

Merged

Conversation

wking
Copy link
Contributor

@wking wking commented Jan 31, 2019

To get the more-robust handling from 0f6535c (#2106) here too.

Fixes #2086 (again :).

To get the more-robust handling from 0f6535c (libpod/image: Use
ParseNormalizedNamed in RepoDigests, 2019-01-08, containers#2106) here too.

Signed-off-by: W. Trevor King <[email protected]>
@mheon
Copy link
Member

mheon commented Jan 31, 2019

Code LGTM
/approve

@rhatdan
Copy link
Member

rhatdan commented Feb 1, 2019

bot, retest this please
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, rhatdan, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
@rhatdan
Copy link
Member

rhatdan commented Feb 1, 2019

bot, retest this please

@openshift-merge-robot openshift-merge-robot merged commit e6426af into containers:master Feb 1, 2019
@wking wking deleted the image-inspect-repo-digests branch February 5, 2019 00:41
@mrunalp
Copy link
Collaborator

mrunalp commented Feb 5, 2019

We need a new podman release with this fix.

@mheon
Copy link
Member

mheon commented Feb 5, 2019

We're planning to cut a 1.0.1 soon for 8 - we can make sure this is one of the backports, and get it into our other streams as well

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants