-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port grouping in ps command output #2664
port grouping in ps command output #2664
Conversation
continuous published ports are grouped in ps output. bugfix: containers#1358 Signed-off-by: Kunal Kushwaha <[email protected]>
Signed-off-by: Kunal Kushwaha <[email protected]>
Hi @kunalkushwaha. Thanks for your PR. I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch?
|
/ok-to-test |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Changes LGTM, but could you also update the examples in the man page too please?
https://github.com/containers/libpod/blob/master/docs/podman-ps.1.md#examples
I tried forwarding 10,000 ports as a test of performance of the code, and the container hung in CNI adding the port mappings for five minutes before I killed it. So I guess perf for this won't be a serious issue. |
Output looks fine |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunalkushwaha, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
groups the continuous ports and display in readable format.
BugFix : #1358
e.g.