Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port grouping in ps command output #2664

Merged
merged 2 commits into from
Mar 16, 2019

Conversation

kunalkushwaha
Copy link
Collaborator

groups the continuous ports and display in readable format.

BugFix : #1358

e.g.

$ podman run -it -p 1000-1006:1000-1006 --rm --name manyports centos /bin/bash

$ podman ps
CONTAINER ID  IMAGE                            COMMAND    CREATED        STATUS            PORTS                             NAMES
ad7b4aa8c420  docker.io/library/centos:latest  /bin/bash  4 seconds ago  Up 4 seconds ago  0.0.0.0:1000-1006->1000-1006/tcp  manyports


continuous published ports are grouped in ps output.
bugfix: containers#1358

Signed-off-by: Kunal Kushwaha <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

Hi @kunalkushwaha. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 15, 2019
@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@haircommander
Copy link
Collaborator

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2019
@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2019

LGTM
@mheon PTAL

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Changes LGTM, but could you also update the examples in the man page too please?

https://github.com/containers/libpod/blob/master/docs/podman-ps.1.md#examples

@mheon
Copy link
Member

mheon commented Mar 15, 2019

I tried forwarding 10,000 ports as a test of performance of the code, and the container hung in CNI adding the port mappings for five minutes before I killed it. So I guess perf for this won't be a serious issue.

@mheon
Copy link
Member

mheon commented Mar 15, 2019

Output looks fine

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2019
@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunalkushwaha, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2019
@openshift-merge-robot openshift-merge-robot merged commit 37467be into containers:master Mar 16, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants