Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Healthcheck doc and completion fixes #3455

Closed
wants to merge 4 commits into from
Closed

Healthcheck doc and completion fixes #3455

wants to merge 4 commits into from

Commits on Jun 28, 2019

  1. Docs: --healthcheck is actually --healtcheck-command 

    Signed-off-by: Hunor Csomortáni <[email protected]>
    Hunor Csomortáni committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    8c3d919 View commit details
    Browse the repository at this point in the history

  2. Docs: tell that healthchecks only work when running as root 

    Avoid users having to guess if the issue is with their setup or the way
they run the commands.

Signed-off-by: Hunor Csomortáni <[email protected]>
    Hunor Csomortáni committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    2eb7923 View commit details
    Browse the repository at this point in the history

  3. Completion: --health-* is actually --healthcheck-* 

    Although this is not compatible with [Docker CLI].

[Docker CLI]: https://docs.docker.com/engine/reference/run/#healthcheck

Signed-off-by: Hunor Csomortáni <[email protected]>
    Hunor Csomortáni committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    066aca2 View commit details
    Browse the repository at this point in the history

  4. Completion: --no-healthcheck is not an option 

    Signed-off-by: Hunor Csomortáni <[email protected]>
    Hunor Csomortáni committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    e404ff1 View commit details
    Browse the repository at this point in the history