Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not activate sd_notify support when varlink #3813

Merged
merged 1 commit into from
Aug 18, 2019
Merged

do not activate sd_notify support when varlink #3813

merged 1 commit into from
Aug 18, 2019

Conversation

baude
Copy link
Member

@baude baude commented Aug 14, 2019

add ability to not activate sd_notify when running under varlink as it
causes deadlocks and hangs.

Fixes: #3572

Signed-off-by: baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2019
@baude baude changed the title do not activate sd_notify support when varlink [wip] do not activate sd_notify support when varlink Aug 14, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M labels Aug 14, 2019
@baude
Copy link
Member Author

baude commented Aug 14, 2019

popping a wip/hold on this until i get a chance to actually test it

@mheon
Copy link
Member

mheon commented Aug 14, 2019

One naming suggestion, core of this seems solid.

@baude baude force-pushed the nofds branch 2 times, most recently from 301fa0a to 8a44790 Compare August 14, 2019 16:45
@baude
Copy link
Member Author

baude commented Aug 14, 2019

/test images

1 similar comment
@baude
Copy link
Member Author

baude commented Aug 14, 2019

/test images

@rhatdan
Copy link
Member

rhatdan commented Aug 15, 2019 •
edited
Loading

This PR is full of double negatives. Wouldn't it be a lot easier to understand if you had it set to EnableNotify Or better yet don't talk about fds, but talk about remote.

In the future we might want libpod to work differently if it is handling a remote client versus a local client. so can we make this more generic.

IsLocal?
IsRemote?

@baude
Copy link
Member Author

baude commented Aug 15, 2019

i dont care what the name is ... but the reality is it has little to do with remote vs local but more about sd notify/listening. It just so happens that when using varlink, we need to turn that off.

@baude
Copy link
Member Author

baude commented Aug 15, 2019

/test images

@mheon
Copy link
Member

mheon commented Aug 15, 2019

I'm fine with making it the inverse - WithEnableSDNotify()

@baude baude changed the title [wip] do not activate sd_notify support when varlink do not activate sd_notify support when varlink Aug 15, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2019
mheon
mheon reviewed Aug 15, 2019
View reviewed changes
libpod/runtime.go Outdated Show resolved Hide resolved
@baude
do not activate sd_notify support when varlink
e667301 
add ability to not activate sd_notify when running under varlink as it
causes deadlocks and hangs.

Fixes: containers#3572

Signed-off-by: baude <[email protected]>
@baude
Copy link
Member Author

baude commented Aug 16, 2019

/retest

TomSweeneyRedHat
TomSweeneyRedHat reviewed Aug 16, 2019
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming happy tests

@rhatdan
Copy link
Member

rhatdan commented Aug 16, 2019

/lgtm
/hold
Cancel hold when tests pass.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 16, 2019
@baude
Copy link
Member Author

baude commented Aug 18, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 438cbf4 into containers:master Aug 18, 2019
@baude baude deleted the nofds branch December 22, 2019 18:59
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@haircommander haircommander haircommander left review comments

@mheon mheon mheon left review comments

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock by doing create/start/getContainer via varlink connection
7 participants
@baude @openshift-ci-robot @mheon @rhatdan @haircommander @TomSweeneyRedHat @openshift-merge-robot