Fix up play kube to use image data

[rhatdan]

podman play kube was ignoring the
imageData.Config
Volumes
WorkingDir
Labels
StopSignal

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@haircommander @baude PTAL

[rhatdan]

Fixes: #5174

[rhatdan]

@gfokkema PTAL

[TomSweeneyRedHat]

LGTM but definitely want a @baude head nod

[gfokkema]

Wow that was fast!

Just built a new Arch package, below looks good to me!

┌─gerlof@gerlof-laptop ~/docker/demo $
└─╼cat demo.Dockerfile 
FROM alpine:latest
WORKDIR /bin
CMD ["pwd"]
┌─gerlof@gerlof-laptop ~/docker/demo $
└─╼cat demo.yaml 
apiVersion: v1
kind: Pod
metadata:
  name: demo_pod
spec:
  containers:
  - image: localhost/demo:1.0
    name: demo_kube
┌─gerlof@gerlof-laptop ~/docker/demo $
└─╼sudo podman play kube demo.yaml 
Pod:
f52609fbfd31a8a7bc68853f00d1020e4741c06fa8650bd98c2494e48ec6f74d
Container:
124dd351e82ee6948f8410292824a9c8add49c29f76c4596c48dd06ff72edb83
┌─gerlof@gerlof-laptop ~/docker/demo $
└─╼sudo podman logs 124dd351e82ee6948f8410292824a9c8add49c29f76c4596c48dd06ff72edb83
/bin

[mheon]

LGTM

[haircommander]

LGTM, though some test cases would be nice 🙂

[vrothberg]

LGTM

[rhatdan]

@haircommander Tests took longer to write then fix the bug. Lets see if they pass, then we can merge.

[vrothberg]

/lgtm