Add support for multiple CNI networks in podman inspect #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Needs tests still. Will add them monday. |
|
Fixes #4907 |
mheon
force-pushed
the
advanced_network_inspect
branch
2 times, most recently
from
dcdd5c5
to
8026f2c
Compare
|
Added tests |
mheon
force-pushed
the
advanced_network_inspect
branch
8 times, most recently
from
9f90851
to
3e012aa
Compare
|
Alright, things are green, minus some flakes. @baude @TomSweeneyRedHat @giuseppe @rhatdan PTAL |
|
LGTM |
|
Oh, wait, this may need a rebase... |
When inspecting containers, info on CNI networks added to the container by name (e.g. --net=name1) should be displayed separately from the configuration of the default network, in a separate map called Networks. This patch adds this separation, improving our Docker compatibility and also adding the ability to see if a container has more than one IPv4 and IPv6 address and more than one MAC address. Fixes containers#4907 Signed-off-by: Matthew Heon <[email protected]>
mheon
force-pushed
the
advanced_network_inspect
branch
from
3e012aa
to
f9fc9a7
Compare
|
Done, should actually go green now |
|
It's green |
|
I guess this does not need an update in man pages. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting containers, info on CNI networks added to the container by name (e.g. --net=name1) should be displayed separately from the configuration of the default network, in a separate map called Networks.
This patch adds this separation, improving our Docker compatibility and also adding the ability to see if a container has more than one IPv4 and IPv6 address and more than one MAC address.