Cleanup OCI runtime before storage

[mheon]

Some runtimes (e.g. Kata containers) seem to object to having us unmount storage before the container is removed from the runtime. This is an easy fix (change the order of operations in cleanup) and seems to make more sense than the way we were doing things.

[rhatdan]

LGTM

[snir911]

doesn't fix the issue :/

[mheon]

Still worth merging, IMO, this makes more sense than the way we did it before.

[mheon]

This does sound like a Kata bug as this point, from what I'm hearing. Podman, on stopping a container, calls the OCI runtime's kill (which should guarantee the container and associated VM stops), and then deletes it from the runtime, and then unmounts storage. This sounds like a correct workflow.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TomSweeneyRedHat]

LGTM
bummer it doesn't fix the bug, but a good change regardless.

[mheon]

I pushed another commit that might actually resolve it, but haven't checked

[rhatdan]

/lgtm

[snir911]

I can confirm this is working, i had a similar version but i was not sure if doing the cleanup before setting the Removing state will make Removing state redundant (or even to regress the bug< #3906> was fixed with 25cc43c)