Add (skopeo generate-sigstore-key) #1869
Conversation
cmd/skopeo/generate_sigstore_key.go
Outdated
| func generateSigstoreKeyCmd() *cobra.Command { | ||
| var opts generateSigstoreKeyOptions | ||
| cmd := &cobra.Command{ | ||
| Use: "generate-sigstore-key --output-prefix PREFIX", |
There was a problem hiding this comment.
I’m not sure about the --output-prefix approach — an alternative is to have --output-public and --output--private, which is more explicit, but also much more typing.
There was a problem hiding this comment.
I like the idea 👍 Naming is always hard and I do not have another idea.
| } | ||
|
|
||
| pubKeyPath := opts.outputPrefix + ".pub" | ||
| privateKeyPath := opts.outputPrefix + ".private" |
There was a problem hiding this comment.
.private or just .key?
.key is somewhat traditional, OTOH users publish private keys often enough that making that harder seems worthwhile.
There was a problem hiding this comment.
👍 on .private. I am very likely such a user that would do it on low caffeine.
mtrmac
force-pushed
the
generate-keys
branch
2 times, most recently
from
747ef09
to
e3682f6
Compare
cmd/skopeo/generate_sigstore_key.go
Outdated
| func generateSigstoreKeyCmd() *cobra.Command { | ||
| var opts generateSigstoreKeyOptions | ||
| cmd := &cobra.Command{ | ||
| Use: "generate-sigstore-key --output-prefix PREFIX", |
There was a problem hiding this comment.
I like the idea 👍 Naming is always hard and I do not have another idea.
| } | ||
|
|
||
| pubKeyPath := opts.outputPrefix + ".pub" | ||
| privateKeyPath := opts.outputPrefix + ".private" |
There was a problem hiding this comment.
👍 on .private. I am very likely such a user that would do it on low caffeine.
|
Now vendors a merged c/image commit, and includes a man page. Ready for review and possible merging. |
|
|
||
| ## OPTIONS | ||
|
|
||
| **--output=prefix** _prefix_ |
There was a problem hiding this comment.
| **--output=prefix** _prefix_ | |
| **--output-prefix=prefix** _prefix_ |
There was a problem hiding this comment.
Thank you! Fixed I think, not quite as suggested.
mtrmac
force-pushed
the
generate-keys
branch
2 times, most recently
from
ad7bf29
to
f72493f
Compare
|
Sorry about that, the script doesn’t run on macOS. It is passing now. |
Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
Depends on unmerged containers/image#1810 , missing documentation - see FIXMEs
@vrothberg PTAL.