store: skip template copy with layer in different store #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
giuseppe
force-pushed
the
idmaps-create-layer-from-another-image-store
branch
from
67481ba
to
2c0bd41
Compare
do not attempt to create a layer using a TemplateLayer if the source layer is in a different store, since the lookup for the source layer would fail in the layers store. The reproducer for the error: Error: error creating container storage: error creating an ID-mapped copy of layer "4fc242d58285699eca05db3cc7c7122a2b8e014d9481f323bd9277baacfa0628": layer not known Closes: containers#1232 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
idmaps-create-layer-from-another-image-store
branch
from
2c0bd41
to
236b9ea
Compare
vrothberg
reviewed
May 9, 2022
|
tests are green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not attempt to create a layer using a TemplateLayer if the source
layer is in a different store, since the lookup for the source layer
would fail in the layers store.
The reproducer for the error:
Error: error creating container storage: error creating an ID-mapped copy of layer "4fc242d58285699eca05db3cc7c7122a2b8e014d9481f323bd9277baacfa0628": layer not known
Closes: #1232
Signed-off-by: Giuseppe Scrivano [email protected]