Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move junkfile to ${TESTDIR} directory #1995

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Jul 2, 2024

This PR moves junkfile to the ${TESTDIR} directory. The junkfile is generated during bats tests in the tests directory. Moving the junkfile to the ${TESTDIR} directory avoids unintended writing this file to the git history.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Honny1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2024
@Honny1 Honny1 marked this pull request as ready for review July 2, 2024 12:58
@Honny1 Honny1 requested a review from giuseppe July 2, 2024 12:58
@nalind
Copy link
Member

nalind commented Jul 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1e48361 into containers:main Jul 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants