overlay: implement DiffGetter #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is needed for: containers/buildah#2359 |
|
What about the other drivers? Don't they at least need the interface? |
it must be customized for each driver, at the moment only aufs has the interface. I am not sure it is even possible for all the remaining drivers to access a file without mounting the layer. |
if the DiffGetter interface is provided, the layer store doesn't need to mount the layer to access the files for tar-split. Signed-off-by: Giuseppe Scrivano <[email protected]>
if the DiffGetter interface is provided, the layer store doesn't need to mount the layer to access the files for tar-split. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
LGTM, but would like someone with more storage chops than I to do a head nod too. |
|
LGTM. The implementations for overlay and vfs mirror the aufs one, which uses a layout for its diffs that is similar to overlay's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the DiffGetter interface is provided, the layer store doesn't need
to mount the layer to access the files for tar-split.
Signed-off-by: Giuseppe Scrivano [email protected]