Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/enter, cmd/run: use /usr/bin/env <shell-name> instead of /bin/<shell-name> #1432

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cmd/enter, cmd/run: use /usr/bin/env <shell-name> instead of /bin/<shell-name> #1432

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 23, 2023 •
edited by ghost
Loading

Fixes #1431. Also replaces runFallbackCommands in src/cmd/run.go with /usr/bin/env .

@ghost ghost changed the title cmd/enter, cmd/run: use /usr/bin/env <shell-name> instead of /usr/bin/<shell-name> cmd/enter, cmd/run: use /usr/bin/env <shell-name> instead of /bin/<shell-name> Dec 23, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b89138694f784114b330ed1deaa27dea

✔️ unit-test SUCCESS in 6m 48s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 14s
✔️ unit-test-restricted SUCCESS in 5m 57s
✔️ system-test-fedora-rawhide SUCCESS in 29m 38s
✔️ system-test-fedora-39 SUCCESS in 31m 11s
✔️ system-test-fedora-38 SUCCESS in 31m 44s

@ghost ghost force-pushed the enter-shell-via-env branch from 75ed503 to cdc803c Compare December 23, 2023 21:33
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/0099018b319546999e1616881d702e18

✔️ unit-test SUCCESS in 6m 31s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 09s
✔️ unit-test-restricted SUCCESS in 5m 51s
✔️ system-test-fedora-rawhide SUCCESS in 31m 16s
✔️ system-test-fedora-39 SUCCESS in 30m 24s
✔️ system-test-fedora-38 SUCCESS in 30m 08s

@ghost ghost mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarryMichal HarryMichal Awaiting requested review from HarryMichal HarryMichal is a code owner

@debarshiray debarshiray Awaiting requested review from debarshiray debarshiray is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toolbox enter: run shell in container via /usr/bin/env <shell-name> instead of using $SHELL directly
1 participant
@dvtfl