Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to build the image from a file #1469

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add a flag to build the image from a file #1469

wants to merge 6 commits into from

Commits on Jul 22, 2024

  1. create-build: added --build option 

    uses the given path as the build context forwarded to podman build

afterwards it extracts the name of the image and sets it to satisfy other
assumption in existing code

the test builds a Fedora 39 toolbx and checks if the image is successfully
tagged as localhost/fedora-toolbox

Signed-off-by: Kilian Hanich <[email protected]>
    @KilianHanich
    KilianHanich committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3bd6c26 View commit details
    Browse the repository at this point in the history

  2. doc: document the added --build option for the create subcommand 

    Signed-off-by: Kilian Hanich <[email protected]>
    @KilianHanich
    KilianHanich committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2fd6b30 View commit details
    Browse the repository at this point in the history

  3. create-build-tag: added --build-tag option 

    tags the built image of --build by forwarding the value to --tag of
podman build

added a test case with and without a repository
registry.fedoraproject.org was choosen as repository because podman doesn't
let one chose arbitrarily

Signed-off-by: Kilian Hanich <[email protected]>
    @KilianHanich
    KilianHanich committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2ca688b View commit details
    Browse the repository at this point in the history

  4. doc: document the added --build-tag option for the create subcommand 

    Signed-off-by: Kilian Hanich <[email protected]>
    @KilianHanich
    KilianHanich committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b868db5 View commit details
    Browse the repository at this point in the history

  5. added missing parameter 

    Signed-off-by: Kilian Hanich <[email protected]>
    @KilianHanich
    KilianHanich committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6e58a0d View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. fixing bugs around the build feature 

    image to build in the tests is also moved to Fedora 38 as the Fedora 39
file doesn't work at the time of writing

Signed-off-by: Kilian Hanich <[email protected]>
    @KilianHanich
    KilianHanich committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b56a4cc View commit details
    Browse the repository at this point in the history